[oracledb] Correct callback style type definition to allow error as null and optional return value for success by sudarshan12s · Pull Request #74833

[oracledb] Correct callback style type definition to allow error as null and optional return value for success by sudarshan12s · Pull Request #74833 · DefinitelyTyped/DefinitelyTyped

@sudarshan12s Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

oracledb — on npm, on unpkg (author is owner)

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 74833,
  "author": "sudarshan12s",
  "headCommitOid": "09392ce9c26bbde689614ba2a7efacba52e42970",
  "mergeBaseOid": "8fe0c8af85c80359cf96a19fb00e423332cf700f",
  "lastPushDate": "2026-04-03T06:45:15.000Z",
  "lastActivityDate": "2026-04-06T07:48:19.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "oracledb",
      "kind": "edit",
      "files": [
        {
          "path": "types/oracledb/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oracledb/oracledb-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "connorjayfitzgerald",
        "dannyb648",
        "jacobwheale",
        "sudarshan12s",
        "sharadraju"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "RyanCavanaugh",
      "date": "2026-04-03T18:28:35.000Z"
    }
  ],
  "mainBotCommentID": 4182178808,
  "ciResult": "pass"
}