System tests by stufisher · Pull Request #120 · DiamondLightSource/python-zocalo

Tests are now found via entry points. Also added a pytest style -k to filter tests.
Probably need a config option to disable certain tests, for example once switched to rabbitmq we won't want to run the activemq test.

I would suggest waiting with this until after RabbitMQ is deployed and support for ActiveMQ is deprecated/removed.
The reason for this is not just the ActiveMQ-specific test, but also that the overall layout of tests may change, eg. other ActiveMQ specific bits will fall away (time.sleep) and the transient. queue namespace will no longer be a thing.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having said that, I'm not hostile to adding this if you're fine with it being completely rewritten later.
I would suggest though to rename the command to zocalo.run_system_tests to match dlstbx and give a stronger sense of what this is about.

Note: The original agreement was that this wouldn't go into the zocalo package, but into zocalo-dls.

I think its useful outside of dls? I already have this running like you on a 30 min basis to test various services.

I keep the esrf specific system tests in an esrf repo (i.e. we have our own file watcher), but i think the general code is useful to all sites?

md converted to rst, cli tool renamed