Home Original page

allow phpmetrics --git option by flavius · Pull Request #122 · EdgedesignCZ/phpqa

zdenekdrahos

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new option to:

Refactoring:

  • if conditions ?
  • maybe phpmetrics.gitBinary would be better name ?
} else {
$args['git'] = $git;
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If conditions are not really understandable without looking into vendor/bin/phpmetrics --help. I would prefer something like that:

$gitBinary = $this->config->value('phpmetrics.git');
if ($gitBinary) {
    $args['git'] = is_file($gitBinary) ? $gitBinary : 'git';
}