Simplify parameter grids by desilinguist · Pull Request #619 · EducationalTestingService/skll
This PR closes #618.
- Change the default parameter grids to be plain dictionaries instead of lists with a single dictionary.
- Update docstrings and documentation to make it more consistent and compatible with this change.
- Update tests.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. Can we also have a test case with empty dictionary parameter grid.
Almost all of our tests in test_classification.py and test_regression.py are with empty parameter grids since we do not specify an explicit parameter grid either via the API or via the config file. So that's already covered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters