I18n check: fix empty comment by spier · Pull Request #586 · InnerSourceCommons/InnerSourcePatterns
I noticed a bug in .github/workflows/i18n-consistency-checker.yaml.
When it runs but doesn't find any issues, it will still create a comment to the existing GitHub issue.
Example: #583 (comment)
This happened because the script wrote a header to issue.md, and later one the existence of the issue.md file was used to confirm whether an issue/comment should be created or not. As the header always exists, this was always true.
I fixes this by breaking up the logic into two main blocks:
a) check for inconsistencies between en and translation
b) if inconsistencies were found, create issue/comment
I am sure that my solution could be greatly improved with some more shell scripting knowledge.
Personally I am not super happy with my introduction of yet another file (issue-full.md). This could have likely been done differently as well.
Looking forward to any input.