Add TrackJSON Download and SkipTranscoding Options. by BryonLewis · Pull Request #1291 · Kitware/dive
- Annotation download button modified within web version to have a dropdown to select the TrackJSON instead of always exporting the viame-csv format
- Logic included preventing transcoding when uploaded with the
skipTranscodingparameter set to true. Should only be done by those who know that their video is h264 encoded.
- Logic included preventing transcoding when uploaded with the
skipTranscodingparameter set to true. Should only be done by those who know that their video is h264 encoded.
What happens if you knowingly enable this option on a video that's not in the right format? (i.e., what kind of error message or error state will the user find themselves in?)
- Logic included preventing transcoding when uploaded with the
skipTranscodingparameter set to true. Should only be done by those who know that their video is h264 encoded.What happens if you knowingly enable this option on a video that's not in the right format? (i.e., what kind of error message or error state will the user find themselves in?)
Currently, it will fall back on transcoding the video. That is probably not desired when importing videos and having that option set. I can easily change it to create an error in the job log.
Note to self: Clarify the setting as being "Attempt to Skip transcoding". It will fall back to transcoding if the video files are not in the proper format. Log this information in the Job log and update the UI elements to accurately indicate to the user this setting (may need to use a help icon tip for the longer explanation).
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, working well. Just minor grammar changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters