fix #99 in createInLocation and add delete server by id by BenjaminLeibinger · Pull Request #102 · LKDevelopment/hetzner-cloud-php-sdk
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! However please don't commit the composer.lock.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, please don't commit the composer.lock
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why shouldn`t we commit the composer.lock? This ensures, that every developer has the same dependency versions. Its also recommended from the composer docu. Composer Doku
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.