Summary

I believe the problem is in DanaKit in commit dcc4495

• loopandlearn/DanaKit@dcc4495

Trouble Shooting:

Last time I tested integration of DanaKit to LoopWorkspace was with DanaKit commit f870821 on April 21, 2025

Problem Summary

The current failure is:

• When adding a Dana pump to Loop

  • the app crashes when you tap Finish after adding the pump
  • the app can be restarted following the crash and the pump appears to work as expected

• When deleting a Dana pump from Loop

  • the app crashes when you tap Delete Pump after requesting delete pump
  • the app can be restarted following the crash and the pump was successfully deleted and a different pump can be added

The crash for both adding and deleting the pump is on line 2057 of LoopWorkspace/Loop/Loop/View Controllers/StatusTableViewController.swift

Identify "problem" commit

review commit list

Look at recent commits for DanaKit (full list at bottom of this comment):

I was suspicious that this commit may have caused an issue with the LoopWorkspace implementation.

• Extra pump events & pump delete
• This changes some returns from nil to [] and from item to [items] among other things.

test with 41b592e

I modified my local clone of LoopWorkspace: feat/dana branch to point to the commit in DanaKit before the one I suspected, i.e., commit 41b592e.

With this commit, the Dana pump is able to be added and deleted from LoopWorkspace without crashing the app and appears to work nominally (using an rPi dana simulator).

test with dcc4495

With this commit, dcc4495, the problem of crashing during addition or removal of the Dana pump returns.

Trio results

Because Trio uses the same repository as LoopWorkspace, I repeated this test with Trio 0.5.1.10. The notes for this are found in Trio PR 720: chore: update DanaKit.

Those tests indicate this commit, dcc4495, also causes an issue for Trio.

complete DanaKit commit list since last successful LoopWorkspace

This is the complete commit list since the successful test in April 2025.

59f4853 (HEAD -> dev, origin/l10n_dev, origin/dev, origin/HEAD) New translations localizable.strings (Polish) (#13)
1ea5e38 chore: linter
dcc4495 Extra pump events & pump delete (#11)
41b592e chore: fix warning
ca240f9 fix: add extra logs for detecting missing PumpDelegate
70610c4 New Crowdin updates (#9)
96c6e3e i18n: update translation
5f14486 New Crowdin updates (#8)
0d54871 style: add DanaRS v1 warning
ee9ebdd chore: linter
fbf1fad style: seperate stop temp basal button from suspend/resume button
49896ef fix: Prevent double Resume & Suspend event recording
3c0336b chore: linting
d73b369 fix: rework async DanaKit
89062b0 fix
8bf3b3a fix: rename log filenames
f870821 fix: update bolus state even with forced disconnect