[CI] Deploy step improvements by harry-cpp · Pull Request #8910

[CI] Deploy step improvements by harry-cpp · Pull Request #8910 · MonoGame/MonoGame

Stuff done:

Add DOTNET_SYSTEM_NET_SECURITY_NOREVOCATIONCHECKBYDEFAULT so that macOS doesn't randomly fail on us as Dean suggested
Fix nuget preparation on Deploy step not properly including mgpipeline library
Make deploy step create a nuget artefact containing the combined set of nuget packages for easier testing

		run: \|
		dotnet run --project build/Build.csproj -- --target=Default
		env:
		DOTNET_SYSTEM_NET_SECURITY_NOREVOCATIONCHECKBYDEFAULT: 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I be picky and ask that we add a comment explaining why we added this to workaround some SSL failures? Just so we remember what this is about in 5 years. Since it's an undocumented thing...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is showing a commit change to templates? Maybe it needs updating from develop @harry-cpp

Not sure why this is showing a commit change to templates? Maybe it needs updating from develop @harry-cpp

Gimme a sec, I'll fix it up.

:D @harry-cpp you fixed the template checkout and removed the comment I added to address @ThomasFOG query :D