Stuff done:

• Remove mgfxc.exe reference from the Content.Pipeline and instead include all the cs code
• Use freshly built mojoshader binaries that are statically linked on all platforms
• Package up Windows dxc.exe inside MonoGame.Tool.Dxc and hook it up so we can now ship dxc on all platforms
• Add ability for mgfxc to only call the needed fxc.exe call under wine while compiling OpenGL shaders
• Add more basic effect compilation unit tests that now also builds stuff for DX12 / Vulkan / OpenGL
• Drop support of automatically relaunching mgfxc under wine
• Drop out of the box support for compiling DirectX 11 shaders on macOS / Linux

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just a concern about Wine for Mac, but otherwise good

What concerns?

Looks fine, just a concern about Wine for Mac, but otherwise good

What concerns?

The concern we had a private chat about regarding the

static bool DetectWine()
        {
            string[] wineCommands = RuntimeInformation.IsOSPlatform(OSPlatform.Linux) ?

Which was clarified to state it was just for changing the order for detecting Wine.

This was clarified and confirmed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.