dask: `Data.__iter__`, `Data.__len__` by davidhassell · Pull Request #321 · NCAS-CMS/cf-python
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. I've raised one question, so please see that before merging, and generally don't forget to mark migrated methods as 'daskified' via the decorator of that name to help us keep track of the migrated methods in the Data module itself (to complement the big table in #295); ideally add in those decorators on each PR, including this PR, before merging. Thanks.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is now a merge conflict to resolve, but otherwise this is all good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters