Home Original page

dask: `Data.flatten` by davidhassell · Pull Request #333 · NCAS-CMS/cf-python

@davidhassell

@davidhassell

sadielbartholomew

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but all good to go, assuming TODODASK - check against daask flatten behaviour has been covered (as per the removed line)?

@davidhassell @sadielbartholomew 

Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>

@davidhassell

Thanks Sadie - you're right that the TODODASK - check against dask flatten behaviour has been covered. It behaves like numpy in that it doesn't allow subsets of axes to be flattened, so that code that does that (the transposing and reshaping) is still there in Data.flatten.

@davidhassell