dask: `Data.__round__` by davidhassell · Pull Request #370 · NCAS-CMS/cf-python
__round__ is not implemented by numpy nor dask - I reckon it's OK to also not implement it here.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue, as raised in-line, otherwise this looks good to me.
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Hi Sadie - just checking if this is good to merge, now?
Hi Sadie - just checking if this is good to merge, now?
Yes, good to go in my eyes; sorry I realise now I had left this on a 'Changes requested' state by accident. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters