dask: Data dump and load serialisations by davidhassell · Pull Request #392 · NCAS-CMS/cf-python
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, though I had one question which may provoke further changes, as below.
- I see that the
loadd=Noneandloads=Nonekeywords remain, along with basic necessary management of those (if loadd is not None:statement and the equivalent), in the constructor method for theDataobject. Is there a reason they have been left in, or can they now be cut too (I suspect they have been missed since they will throw an error as-is for this PR, I believe)?
Good spot - those keywords and their associated code have gone: ed0683d
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have sanity checked the new commit and this is ready to go. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters