dask: Data dump and load serialisations by davidhassell · Pull Request #392 · NCAS-CMS/cf-python

@davidhassell

@davidhassell

sadielbartholomew

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, though I had one question which may provoke further changes, as below.

  • I see that the loadd=None and loads=None keywords remain, along with basic necessary management of those (if loadd is not None: statement and the equivalent), in the constructor method for the Data object. Is there a reason they have been left in, or can they now be cut too (I suspect they have been missed since they will throw an error as-is for this PR, I believe)?

@davidhassell

@davidhassell

Good spot - those keywords and their associated code have gone: ed0683d

sadielbartholomew

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have sanity checked the new commit and this is ready to go. Thanks.