dask: `Field.argmax` by davidhassell · Pull Request #557 · NCAS-CMS/cf-python
I haven't been assigned to this but assume you want me to review it (after the regridding PR) @davidhassell, so will self-assign. Unassign me if I'm wrong, and note some conflicts need to be resolve. Thanks.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've raised a few minor comments but overall this is all good. Please merge when ready.
One quick question, also: why do we have an argmax but not argmin method on both Data and Field? Seems weird to me to have one and not both...
Hi Sadie - there's no argmin simply because there wasn't one before, and I didn't want to create extra work right now. We'll put it in for 4.0.0 (I'll open an issue so we don't forget).
See: #577
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters