[IR] Support SelectRowsType by zhangbo9674 · Pull Request #55041

[IR] Support SelectRowsType by zhangbo9674 · Pull Request #55041 · PaddlePaddle/Paddle

PR types

New features

PR changes

Others

Description

支持 SelectRowsType、添加 embedding_grad_sparse 算子

Other

Pcard-67164

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

		using ParamKey =
		std::tuple<ir::Type, phi::DDim, phi::DataLayout, phi::LoD, size_t>;

		SelectedRowsTypeStorage(ir::Type dtype,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const & 替换「值传递」？

		/// \brief Each derived TypeStorage must define a Construct method, which
		/// StorageManager uses to construct a derived TypeStorage.
		///
		static SelectedRowsTypeStorage* Construct(ParamKey key) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前的PR已经统一这里了，应该都是const &

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, tks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM