Provide opoperands(), opresults() methods for the Operation module by jjyaoao · Pull Request #55903 · PaddlePaddle/Paddle
你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其实这个任务是期望给 operation.h 的 Operation 里加两个接口的[捂脸],不是这里utils里的OperationArgument~~
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其实这个任务是期望给 operation.h 的 Operation 里加两个接口的[捂脸],不是这里utils里的OperationArgument~~
Done
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其实在pybind层已经有实现了。可以把这个两个函数的实现分别copy到Operation类里面,然后把pybind ir.cc文件里直接改为类似.def("result", &Operation::result)这样的直接函数映射形态即可~~
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其实在pybind层已经有实现了。可以把这个两个函数的实现分别copy到Operation类里面,然后把pybind ir.cc文件里直接改为类似.def("result", &Operation::result)这样的直接函数映射形态即可~~
Done
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters