update signing file for versioned location of module by JamesWTruher · Pull Request #1253 · PowerShell/PSScriptAnalyzer
PR Summary
These are the changes to build and sign script analyzer in VSTS.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's up to you but I suggest to do XML editing the file at runtime to put the version number into it, even just putting a placeholder and doing a simple string replace would do the job as well IMHO whilst keeping it simple
@bergmeister Agreed - when we move to VSTS CI I'm planning on a bit of a rewrite to generate more of this. For 1.18.1 I'll just do it manually, especially as the release is imminent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters