Fix rule suppression ID in compat rules by rjmholt · Pull Request #1432 · PowerShell/PSScriptAnalyzer
PR Summary
The ruleId wasn't translated through in the compatibility diagnostic constructor. This fixes that.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can an existing test be enhanced for an additional assertion against the rule id if easily possible? Otherwise LGTM
Can an existing test be enhanced for an additional assertion against the rule id if easily possible?
I'm thinking a similar thing, but I'd like to do that in a separate PR (which might be able to enhance these suppressions slightly as well)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
