Fix rule suppression ID in compat rules by rjmholt · Pull Request #1432 · PowerShell/PSScriptAnalyzer

@rjmholt

PR Summary

The ruleId wasn't translated through in the compatibility diagnostic constructor. This fixes that.

PR Checklist

@rjmholt

TylerLeonhardt

@rjmholt

image

bergmeister

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can an existing test be enhanced for an additional assertion against the rule id if easily possible? Otherwise LGTM

@rjmholt

Can an existing test be enhanced for an additional assertion against the rule id if easily possible?

I'm thinking a similar thing, but I'd like to do that in a separate PR (which might be able to enhance these suppressions slightly as well)