AvoidLongLines: Make internal function DiagnosticSeverity private by bergmeister · Pull Request #1851 · PowerShell/PSScriptAnalyzer
PR Summary
Code analysis showed that this function is only used by the rule itself, therefore it shouldn't have been public. No change of behavior. Technically breaking but this method was never intended to be public and other rules do not have public methods to return the DiagnosticSeverity they will emit, in fact depending on the analysis they might be different.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix