Make the experimental feature `PSFeedbackProvider` stable by daxian-dbw · Pull Request #26343 · PowerShell/PowerShell
Pull Request Overview
This PR removes the legacy suggestion framework that was replaced by the extensible feedback provider system. The changes eliminate the hard-coded suggestion mechanism and its associated experimental feature flag (PSFeedbackProvider), consolidating on the newer feedback provider approach.
- Removes the
PSFeedbackProviderexperimental feature flag and related legacy suggestion infrastructure - Deletes legacy suggestion methods and related enums from
HostUtilities.cs - Removes conditional logic that checked the experimental feature flag and always uses the feedback provider
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/System.Management.Automation/resources/SuggestionStrings.resx | Removes the legacy suggestion string resource that was used by the old suggestion framework |
| src/System.Management.Automation/engine/hostifaces/HostUtilities.cs | Removes legacy suggestion infrastructure including SuggestionMatchType enum, suggestion initialization methods, and GetSuggestion methods along with unused imports |
| src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs | Removes the PSFeedbackProvider experimental feature constant and its registration |
| src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs | Removes conditional logic and the EvaluateSuggestions method, always using EvaluateFeedbacks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.