FOUR-15875 Optimize Script Tasks Execution with Nayra Engine by caleeli · Pull Request #6942 · ProcessMaker/processmaker

@caleeli

Optimize Script Tasks Execution with Nayra Engine

image image

How to Test

  • Go to the script executors
  • Build and deploy the Nayra-PHP Executor
  • Create a PHP-Nayra Script
  • Add some php code to test
  • Run it!

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:deploy

FOUR-15871 Optimize Interstitial to Reduce Redundant Task Calls

@caleeli

@caleeli

@caleeli

@caleeli

julceslauhub


class CreateNayraScriptExecutor extends Upgrade
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete this empty line

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

julceslauhub

$scriptExecutor->save();
}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing "down" method

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing method was added

@processmaker-sonarqube

julceslauhub

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@caleeli

@caleeli