FOUR-20504 enhance test coverage for settings functionality before adding cache by devmiguelangel · Pull Request #7766 · ProcessMaker/processmaker
Issue & Reproduction Steps
Complete the Test coverage of Settings by adding at least the following one:
- Security Logging: Testing the security logging functionality when changing Settings
- Format Handling: Testing different data format support (could be saml or email,…)
- Validation: Fix, update or remove the skipped tests
Solution
- Add missing tests for core settings
- Add missing tests for security logs when a setting is updated
- Add missing tests for setting formats
How to Test
- Run
php artisan test --filter 'SettingLogInOptionsTest|SettingSessionControlTest|SettingAuthTest'
Related Tickets & Packages
Code Review Checklist
- I have pulled this code locally and tested it on my instance, along with any associated packages.
- This code adheres to ProcessMaker Coding Guidelines.
- This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
- This solution fixes the bug reported in the original ticket.
- This solution does not alter the expected output of a component in a way that would break existing Processes.
- This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
- This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
- This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
- This ticket conforms to the PRD associated with this part of ProcessMaker.