add -tdlib=libc++ argument by ncourty · Pull Request #72 · PythonOT/POT
| opt_arg=["-O3"] | ||
| import platform | ||
| if platform.system()=='Darwin': | ||
| if platform.release()=='18.0.0': |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't you use >= instead, i don't think this option will be necessary on just of release of MacSOX
| if platform.release()=='18.0.0': | |
| if platform.release()>='18.0.0': |
PS trying the suggestion thing it's nice.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about the suggestion. In its form I think the bug is partly due to the fact that python Extension module has trouble to get the correct path from the new locations of clang compiler on the new OSX. I hope this will be corrected in the future. Clearly it is a temporary patch here.
| README = f.read() | ||
|
|
||
| # add platform dependant optional compilation argument | ||
| opt_arg=["-O3"] |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch