Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when tests pass. though i don't think the current approach to scrolling into view is very nice, that is a long term problem to fix.

do you think we need an interface for "Scroll-into-view-able"?

or should these components do this automatically in their "onNodeFocus" methods? is there a time when a node is focused that we wouldn't want to scroll them into view?

these are just rhetorical questions for now. i'll file an issue for them.