The basics

• I validated my changes

The details

Resolves

Fixes #9473

Proposed Changes

Consistently use getMenuItems() for highlight methods in dropdown menus.

Reason for Changes

The getMenuItems() method filters out menu separators that otherwise break keyboard navigation in the menus due to an index error.

Test Coverage

Documentation

Additional Information

Just to check, is this ready for review @microbit-robert or ongoing? I notice some CI failures so I wanted to check.

Also due to the repository migration we don't have auto-reviewer assignment working anymore so that needs to be done manually (for now).

@BenHenning I rebased on latest develop which has fixed most of the failures. I'm not sure that the remaining keyboard nav test failures are related to this change.

@BenHenning I rebased on latest develop which has fixed most of the failures. I'm not sure that the remaining keyboard nav test failures are related to this change.

Thanks. I agree that the CI issues should be unrelated.