Home Original page

BUG: Sideslip Angle and Damping Coefficient Calculation by MateusStano · Pull Request #729 · RocketPy-Team/RocketPy

@MateusStano

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Description

Fixed the calculation of the angle of sideslip to be in accordance with the documentation.

Fixed the sign of the damping coefficient in the LinearGenericSurface

Co-authored-by: kevin-alcaniz <kevinalcaniz22@gmail.com>
Co-authored-by: kevin-alcaniz <kevinalcaniz22@gmail.com>

@MateusStano

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.08%. Comparing base (a6a0f74) to head (1574aea).
Report is 18 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #729      +/-   ##
===========================================
+ Coverage    75.95%   76.08%   +0.12%     
===========================================
  Files           99       95       -4     
  Lines        11237    10997     -240     
===========================================
- Hits          8535     8367     -168     
+ Misses        2702     2630      -72

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gui-FernandesBR

Gui-FernandesBR

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MateusStano