Home Original page

MNT: Place filename save parameter to the end. by phmbressan · Pull Request #739 · RocketPy-Team/RocketPy

@phmbressan

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

New behavior

As described by the conversation in #731 , this PR moves the filename parameter to the end so as to avoid potential future breaking changes.

Breaking change

  • Yes
  • No

@phmbressan

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.97%. Comparing base (e1a2061) to head (e723768).
Report is 15 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #739      +/-   ##
===========================================
- Coverage    75.99%   75.97%   -0.02%     
===========================================
  Files           95       95              
  Lines        11015    11027      +12     
===========================================
+ Hits          8371     8378       +7     
- Misses        2644     2649       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gui-FernandesBR

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gui-FernandesBR