Bug: do not allow drawing rockets with no aerodynamic surface by Gui-FernandesBR · Pull Request #774 · RocketPy-Team/RocketPy
Pull request type
- Code changes (bugfix, features)
- Code maintenance (refactoring, formatting, tests)
- ReadMe, Docs and GitHub updates
- Other (please describe):
Checklist
- Docs have been reviewed and added / updated
- Lint (
black rocketpy/ tests/) has passed locally -
CHANGELOG.mdhas been updated (if relevant)
Current behavior
See #766,
When calling rocket.all_info() on a "surfaceless rocket", it throw an error.
New behavior
Now you will see no more errors when trying to print out information from a rocket without aero surfaces.
Breaking change
- No
Additional information
I tested with the getting started notebook. Everything is looking fine.
Essentially: if you do not define any aerodynamic surface, why in the world would you want to draw the rocket? Sorry but we can't.