Home Original page

EHN: Addition of ensemble variable to ECMWF dictionaries by LucasVGon · Pull Request #842 · RocketPy-Team/RocketPy

Conversation

@LucasVGon

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

New behavior

With this small change it is possible to use ensemble files from ERA5 database, which might be usefull for Monte Carlo Simulations.

Enter text here...

Breaking change

  • Yes
  • No

@Gui-FernandesBR

  1. @LUCKIN13 , it is critical that we run slow tests before merging this PR
  2. Do you think we could update the documentation to clearly state to the users they can now use this feature?
  3. The CHANGELOG needs to be updated.

@codecov

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.02%. Comparing base (f17893b) to head (a8e7f7d).
⚠️ Report is 21 commits behind head on develop.

Additional details and impacted files 
@@            Coverage Diff            @@
##           develop     #842    +/-   ##
=========================================
  Coverage    80.02%   80.02%            
=========================================
  Files           98      103     +5     
  Lines        12004    12528   +524     
=========================================
+ Hits          9606    10026   +420     
- Misses        2398     2502   +104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucasVGon

  1. @LUCKIN13 , it is critical that we run slow tests before merging this PR
  2. Do you think we could update the documentation to clearly state to the users they can now use this feature?
  3. The CHANGELOG needs to be updated.

Will do all that asap

@LucasVGon

All slow tests passed.
Funny thing is that this possibility was already in the documentation, even though the ECMWF dictionary didn't have the ensemble parameter.

MateusStano