BUG: correct encoding for trapezoidal sweep length and angle. by phmbressan · Pull Request #861 · RocketPy-Team/RocketPy
Pull request type
- Code changes (bugfix, features)
Checklist
- Tests for the changes have been added (if needed)
- Lint (
make format) has passed locally - All tests (
pytest tests -m slow --runslow) have passed locally -
CHANGELOG.mdhas been updated (if relevant)
Current behavior
sweep length and sweep_angle were erroneously not included in the minimal encoding of TrapezoidalFins, causing fins that customize these parameters have incorrect decoding.
New behavior
The parameters were added to the encoding and are handled on decode. Tests were introduced to validate the desired values.
Breaking change
- Yes
- No