Env/flight axial aceleration by hogatata · Pull Request #876 · RocketPy-Team/RocketPy
Pull request overview
This PR aims to add axial acceleration calculation to the Flight class, which represents the acceleration along the rocket's longitudinal axis. However, the PR includes several unrelated changes that significantly expand its scope beyond the stated purpose.
Key Changes:
- Added
axial_accelerationproperty to calculate acceleration along rocket's axis - Added corresponding unit test using dot product verification
- Unexpectedly restored previously deprecated export methods (
export_pressures,export_data,export_sensor_data,export_kml) with full implementations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| rocketpy/simulation/flight.py | Added axial_acceleration cached property; restored export methods that were previously moved to FlightDataExporter; removed self.apogee initialization; added json and simplekml imports; removed deprecated import |
| tests/unit/simulation/test_flight.py | Added parameterized test to verify axial_acceleration calculation against manual dot product computation at key flight times |