rust_is_available: exit showing the documentation by aliceinwire · Pull Request #932 · Rust-for-Linux/linux
Thanks for this!
Related patch: https://lore.kernel.org/rust-for-linux/20221004184625.10076-1-olof@lixom.net/ where Olof suggested giving explicit suggestions, while I recommended linking to the documentation instead as you do here -- so not sure if you saw that patch or you had the same thought as I did.
Either way, I think it is fine if this helps others! Maybe we could simplify to a single line if it fits, e.g.
Please refer to Documentation/rust/quick-start.rst
The URL is nice to click on many terminals, though the local resource is also typically easy to open too; plus it is for sure for the version one is attempting to compile (i.e. requirements or instructions could change, the document itself could move...) and goes in line with what other comments in Makefiles do (though those are just comments, i.e. not displayed).
Thanks for this!
Related patch: https://lore.kernel.org/rust-for-linux/20221004184625.10076-1-olof@lixom.net/ where Olof suggested giving explicit suggestions, while I recommended linking to the documentation instead as you do here -- so not sure if you saw that patch or you had the same thought as I did.
Thanks you, no I was not aware of that patch. Thanks for linking it.
Either way, I think it is fine if this helps others! Maybe we could simplify to a single line if it fits, e.g.
Please refer to Documentation/rust/quick-start.rstThe URL is nice to click on many terminals, though the local resource is also typically easy to open too; plus it is for sure for the version one is attempting to compile (i.e. requirements or instructions could change, the document itself could move...) and goes in line with what other comments in
Makefiles do (though those are just comments, i.e. not displayed).
I personally open links from terminal, so I was suggesting to add it as a link but I actually prefer your suggestion.
Updated the patch with your suggestion.
Thanks,
Alice
exit function providing a documentation link Signed-off-by: Alice Ferrazzi <alice.ferrazzi@miraclelinux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters