[py] Bump requirements for packaging and dev by cgoldberg · Pull Request #15909 · SeleniumHQ/selenium
Conversation
User description
💥 What does this PR do?
This PR updates all Python dependencies to the latest versions for development and packaging.
This also includes an update to a unit test to reflect new behavior of retries in urllib3, and some minor test cleanup.
🔄 Types of changes
- Dev/CI/Packaging
PR Type
Other
Description
• Update Python dependencies to latest versions
• Bump tox from 4.25.0 to 4.27.0 in CI workflows
• Update urllib3 from 2.4.0 to 2.5.0 in pyproject.toml
• Refresh requirements.txt and lock file with latest versions
Changes walkthrough 📝
| Relevant files | |||||||||
|---|---|---|---|---|---|---|---|---|---|
| Dependencies |
|
Need help?
Type /help how to ...in the comments thread for any questions about Qodo Merge usage.Check out the documentation for more information.
PR Reviewer Guide 🔍
Here are some key observations to aid the review process:
| ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪ |
| 🧪 No relevant tests |
| 🔒 No security concerns identified |
⚡ Recommended focus areas for reviewPackage Removal
|
The upgrade of urllib3 from 2.4.0->2.5.0 breaks the unit test:
py/test/unit/selenium/webdriver/remote/remote_connection_tests.py::test_get_connection_manager_with_custom_args
This test sets an integer for the retry when creating a urllib3.PoolManager: {"retries": 3, "block": True}}
It fails with:
> assert conn.connection_pool_kw["retries"] == 3
E assert Retry(total=3, connect=None, read=None, redirect=0, status=None) == 3
in 2.4.0 the value of retries was an integer.
in 2.5.0 the value of retries is an instance of urllib3.util.Retry
I have no idea what the repercussions of this are, but this needs investigation before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters