Home Original page

[dotnet] Mark FTP proxy support as deprecated by iampopovich · Pull Request #15925 · SeleniumHQ/selenium

Conversation

@iampopovich

User description

🔗 Related Issues

Contributes to #15905

💥 What does this PR do?

This pull request adds a deprecation warning to the FtpProxy property in the Proxy.cs file with the single line of code as was requested

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Other

Description

  • Mark FTP proxy property as deprecated with obsolete attribute

Changes walkthrough 📝

Relevant files
Deprecation
Proxy.cs
Deprecate FTP proxy property                                                         

dotnet/src/webdriver/Proxy.cs

  • Added [Obsolete] attribute to FtpProxy property with deprecation
    message
    		• +1/-0     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.

    • @qodo-code-review

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review
    Version Specificity

    The deprecation message specifies removal in version 4.37, but this should be verified against the project's versioning strategy and roadmap to ensure accuracy.

     
    [Obsolete("FTP proxy support is deprecated and will be removed in the 4.37 version.")]
public string? FtpProxy

    @qodo-code-review

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    nvborisenko

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks for your contribution!

    Labels