Home Original page

[dotnet] [bidi] Preserve BiDi global options when instantiating BiDi by nvborisenko · Pull Request #16080 · SeleniumHQ/selenium

User description

It will be used to setting some global options, like command timeout (30 secs by default as for now).

💥 What does this PR do?

Preserving method signature for further improvements without any breaking changes.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • Bug fix (backwards compatible)
  • New feature (non-breaking change which adds functionality and tests!)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Type

Enhancement

Description

  • Add BiDiOptions class for future BiDi configuration

  • Update AsBiDiAsync method to accept optional BiDi options

  • Preserve method signature for backwards compatibility

Diagram Walkthrough

flowchart LR
  A["BiDiOptions class"] --> B["AsBiDiAsync method"]
  B --> C["Future configuration support"]
Loading

File Walkthrough
Relevant files
Enhancement
BiDiOptions.cs
Create BiDiOptions configuration class                                     

dotnet/src/webdriver/BiDi/BiDiOptions.cs

  • Create new BiDiOptions sealed class
  • Add standard Apache License header
  • Empty class ready for future configuration properties
 +24/-0   
WebDriver.Extensions.cs
Update AsBiDiAsync method signature                                           

dotnet/src/webdriver/BiDi/WebDriver.Extensions.cs

  • Add optional BiDiOptions parameter to AsBiDiAsync method
  • Maintain backwards compatibility with default null value
 +1/-1