Renaming variable and converting it to nullable bool? by diemol · Pull Request #16138

Renaming variable and converting it to nullable bool? by diemol · Pull Request #16138 · SeleniumHQ/selenium

🎫 Ticket compliance analysis ❌ 1234 - Not compliant Non-compliant requirements: • Fix JavaScript execution in link href on click() for Firefox driver • Ensure compatibility with Firefox 42.0 and Selenium 2.48.x versions • Restore functionality that worked in version 2.47.1 5678 - Not compliant Non-compliant requirements: • Fix ChromeDriver ConnectFailure error on Ubuntu 16.04.4 • Resolve connection refused errors for subsequent ChromeDriver instances • Ensure proper ChromeDriver instantiation beyond the first instance
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Logic Error The property name `LogTruncate` suggests enabling truncation when true, but the implementation adds `--log-no-truncate` flag when the value is true, which disables truncation. This creates confusing semantics where LogTruncate=true actually means disable truncation. /// Gets or sets a value indicating whether to disable truncation of long log lines in GeckoDriver. /// </summary> /// <remarks> /// A <see langword="null"/> value indicates no log truncation setting to specify. /// Set to <see langword="true"/> to disable truncation, or <see langword="false"/> to enable truncation. /// </remarks> public bool? LogTruncate { get; set; }