Home Original page

[java] JSpecify annotations for `org.openqa.selenium.bidi.permissions` by mk868 · Pull Request #16430 · SeleniumHQ/selenium

User description

🔗 Related Issues

Related #14291

💥 What does this PR do?

JSpecify annotations added to the:

  • org.openqa.selenium.bidi.permissions.PermissionState

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • New feature (non-breaking change which adds functionality and tests!)

PR Type

Enhancement

Description

  • Added JSpecify nullability annotations to PermissionState enum

  • Marked findByName method return type as @Nullable

  • Added @NullMarked annotation at class level for null safety

  • Updated build configuration to include JSpecify dependency

Diagram Walkthrough

flowchart LR
  A["PermissionState enum"] --> B["Add @NullMarked annotation"]
  A --> C["Mark findByName as @Nullable"]
  D["BUILD.bazel"] --> E["Add JSpecify dependency"]
Loading

File Walkthrough
Relevant files
Enhancement
PermissionState.java
Add JSpecify nullability annotations to PermissionState enum

java/src/org/openqa/selenium/bidi/permissions/PermissionState.java

  • Added @NullMarked annotation at class level
  • Imported JSpecify annotations (NullMarked, Nullable)
  • Marked findByName method return type as @Nullable
 +5/-1     
Dependencies
BUILD.bazel
Add JSpecify dependency to permissions build configuration

java/src/org/openqa/selenium/bidi/permissions/BUILD.bazel

  • Added artifact import to build file
  • Added JSpecify dependency to deps list
 +4/-1