[build] Pre-release workflow improvements by titusfortner · Pull Request #16946 · SeleniumHQ/selenium
| Security Compliance | |
| ⚪ | Unpinned GitHub ActionsDescription: Multiple third-party GitHub Actions are referenced by mutable tags (e.g., Referred Codeget-approval: name: Get Approval uses: ./.github/workflows/get-approval.yml with: title: Release approval needed message: | Selenium ${{ github.event.inputs.version }} release preparation started. Please approve to lock trunk when ready. secrets: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} update-rust: name: Update Rust Version runs-on: ubuntu-latest if: github.event.repository.fork == false steps: - name: "Checkout repo" uses: actions/checkout@v4 with: persist-credentials: false fetch-depth: 0 ... (clipped 168 lines) |
| Ticket Compliance | |
| ⚪ | 🎫 No ticket provided
|
| Codebase Duplication Compliance | |
| ⚪ | Codebase context is not definedFollow the guide to enable codebase context checks. |
| Custom Compliance | |
| 🟢 |
Generic: Comprehensive Audit TrailsObjective: To create a detailed and reliable record of critical system actions for security analysis Status: Passed
|
Generic: Meaningful Naming and Self-Documenting CodeObjective: Ensure all identifiers clearly express their purpose and intent, making code Status: Passed
| |
Generic: Secure Error HandlingObjective: To prevent the leakage of sensitive system information through error messages while Status: Passed
| |
Generic: Secure Logging PracticesObjective: To ensure logs are useful for debugging and auditing without exposing sensitive Status: Passed
| |
| 🔴 | Generic: Robust Error Handling and Edge Case ManagementObjective: Ensure comprehensive error handling that provides meaningful context and graceful Status: Referred Code- name: Normalize version id: version run: | VERSION="${{ github.event.inputs.version }}" if [[ "$VERSION" =~ ^[0-9]+\.[0-9]+$ ]]; then VERSION="${VERSION}.0" fi echo "value=$VERSION" >> "$GITHUB_OUTPUT" - name: Update browser versions
|
Generic: Security-First Input Validation and Data HandlingObjective: Ensure all data inputs are validated, sanitized, and handled securely to prevent Status: Referred Code- name: Normalize version id: version run: | VERSION="${{ github.event.inputs.version }}" if [[ "$VERSION" =~ ^[0-9]+\.[0-9]+$ ]]; then VERSION="${VERSION}.0" fi echo "value=$VERSION" >> "$GITHUB_OUTPUT" - name: Update browser versions id: browsers run: | ./go update_browsers ${{ github.event.inputs.chrome_channel }} if git diff --staged --quiet; then echo "updated=false" >> "$GITHUB_OUTPUT" else git commit -m "update pinned browser versions" echo "updated=true" >> "$GITHUB_OUTPUT" fi - name: Update devtools versions id: devtools run: | ... (clipped 41 lines)
| |
| |