Fix vCard bugs; import RFCs by Shane32 · Pull Request #621 · Shane32/QRCoder
50-50: LGTM!
The updated expected string correctly reflects the MeCard ADR format with address components in the proper order (PO Box, Extended Address, Street, Locality, Region, Postal Code, Country).
108-108: LGTM!
The updated expected string correctly includes the vCard 2.1 address type format (ADR;HOME;PREF:) and follows RFC 2426 Section 3.2.1 structure for address components.
137-137: LGTM!
The updated expected string correctly uses vCard 3.0 TYPE parameter syntax (ADR;TYPE=HOME,PREF:) with comma-separated type values, consistent with RFC 2426 Section 3.2.1.
166-166: LGTM!
The updated expected string correctly uses vCard 4.0 lowercase TYPE parameter syntax (ADR;TYPE=home,pref:), consistent with vCard 4.0 conventions.
198-223: LGTM!
The new test correctly validates work address generation for vCard 3.0. It properly:
- Passes
AddressType.Workexplicitly to the constructor - Expects the correct vCard 3.0 TYPE format (
ADR;TYPE=WORK:) - Handles empty state/region field correctly (double semicolon)
- Follows the established test pattern
225-250: LGTM!
The new test correctly validates work preferred address generation for vCard 4.0. It properly:
- Passes
AddressType.WorkPreferredexplicitly to the constructor - Expects the correct vCard 4.0 lowercase TYPE format with PREF (
ADR;TYPE=work,pref:) - Handles empty state/region field correctly (double semicolon)
- Follows the established test pattern