Home Original page

Add support for GETDEL command by WeihanLi · Pull Request #1840 · StackExchange/StackExchange.Redis

@WeihanLi

@WeihanLi

mgravell

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, ta. Please could you add to the release notes md file, in the unreleased section, thanks. An integration test would be ideal, but I don't know if our CI redis servers offer this feature - would have to check.

@WeihanLi

@WeihanLi

@WeihanLi

Thanks @mgravell, the command order had been updated to be alphabetical and the release notes had been added.
From the Redis docs, GETDEL is available since 6.2.0.

@WeihanLi

@WeihanLi

Hi @mgravell , the integration test had been added and I had test it locally on my side, any more changes needed?
Could you please help to have a look?

@WeihanLi

@NickCraver

NickCraver

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additions and the tweaks here - looking great!