Support the ZMSCORE command. by ttingen · Pull Request #2082 · StackExchange/StackExchange.Redis
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed up doc tweaks for ease there, just a few requests on the processor and tests (happy to push to branch if easier and you're slammed). Thanks for this!!
@NickCraver all done with the requested changes. Let me know if there is anything else.
@ttingen Made a few quick changes to normalization and naming (I see why keys in tests were confusing where above we did need 2 unique keys - sorry about that!) - will try to do a top-down review in a bit!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ttingen I think current is good - thank you! I'd appreciate @slorello89 eyes here when time allows.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow missed the request @NickCraver sorry about that! LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters