Home Original page

Support COMMAND [...] by shacharPash · Pull Request #2143 · StackExchange/StackExchange.Redis

@shacharPash

@shacharPash

@NickCraver

I just see some trailing spaces on tests to tidy - wanted to comment early this is looking great!

@shacharPash

@chayim

NickCraver

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to catch up a bit - thanks for this! The first set looks good, but I think the second set is split up a bit too much - normally in our API patterns you'd expect 1 command with some arguments for CommandGetkeys, so let's collapse that down to the main CommandGetkeys() method with string params for the 3 possible filters :)

@shacharPash

NickCraver

NickCraver

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current is looking great - thanks for the work here!