`<Avatar>` dimensions and screen reader text by abovedave · Pull Request #2206 · StackExchange/Stacks
- Closes
<Avatar>Svelte component img should have width and height defined #2205 to avoid the layout shift before an image loads. - Begins to address A11Y-126 by using the title prop i.e.,
<Icon title="Private">, which removes thearia-hidden="true".
Add nested img dimensions and screen reader text for private badge.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abovedave We should update the related unit tests to account for the changes you made. I also would not want to hardcode the word "Private" in the component. We use the i18nxxx prop pattern to allow consumers to override default values. Apart from that looks good. Thanks for the PR. ❤️
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abovedave this PR looks good! I added a few tests for these changes and I think it should be all good to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters