Add the ability to define imagePullSecrets for service account by cognifloyd · Pull Request #196 · StackStorm/stackstorm-k8s
If pods do not have imagePullSecrets, they get populated from the ServiceAccount[1]. In our k8s cluster, we prefer defining them on the ServiceAccount so that there are fewer places to update if a change is required.
Effectively, this means we can use serviceAccount.pullSecret instead of image.pullSecret in values.yaml.
[1] From the k8s docs:
- If the pod does not contain any imagePullSecrets, then imagePullSecrets of the ServiceAccount are added to the pod.
TODO:
- PR description
- changelog entry