add pod graceful timeout override by guzzijones · Pull Request #374 · StackStorm/stackstorm-k8s
Conversation
add graceful timeout option for pods.
this will allow a user to override it in values.yaml.
we need this to to along with the graceful timeout settings in st2actionrunner and st2workflowengine.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very helpful!
Just requested a couple minor changes about defaults and docs for this setting.
Please also don't forget to include the Changelog.
| {{- if and .Values.st2.packs.images (not .Values.st2.packs.volumes.enabled) }} | ||
| {{- include "stackstorm-ha.packs-initContainers" . | nindent 6 }} | ||
| {{- end }} | ||
| terminationGracePeriodSeconds: {{ .Values.st2actionrunner.terminationGracePeriodSeconds | default 300 }} |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 300 default looks pretty much hidden from the user's perspective.
values.yaml
Outdated
Show resolved
Hide resolved
add suggestion around terminationgraceperiodseconds Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
@armab I added the requested changes.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters