Default constructor for jwks object by justend29 · Pull Request #346 · Thalhammer/jwt-cpp
Conversation
I appreciate the design to always uphold the invariants of every type.
For jwt::jwks, which is an object holding a collection of jwks, constructing an empty collection of jwks is valid and maintains the invariants of the type.
The motivation for this is encapsulating jwt::jwks in a caching class, where JWKs are often cached with periodic refreshing. There aren't any keys until fetched from issuer. I found myself doing jwt::jwks{"{\"keys\":[]}"} since there wasn't a default constructor, which feels silly.
whoever created the CI job to not only indicate exactly where the lining error is, but also generate a patch file and sample commands to apply it deserves a gold star.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters