Consuming 3.0 actions/cache by tiwarishub · Pull Request #834

Consuming 3.0 actions/cache by tiwarishub · Pull Request #834 · actions/cache

Conversation

We recently published actions/cache 3.0, which suppresses all the errors related caching except validation one. In this PR we are consuming that package to that error handling can be moved cache package.

		const cacheId = await cache.saveCache(cachePaths, primaryKey, {
		uploadChunkSize: utils.getInputAsInt(Inputs.UploadChunkSize)
		});
		if (cacheId == -1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do -

if (cacheId != -1) {
    core.info(`Cache saved with key: ${primaryKey}`);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced

Oct 4, 2022

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

2 participants