Update Maven to 3.9.9, Wrapper to 3.3.2 by afranken · Pull Request #2425 · adobe/S3Mock
Pull Request Overview
This PR updates the Maven Wrapper by bumping the Maven distribution from 3.9.6 to 3.9.9 and the wrapper version from 3.2.0 to 3.3.2, with corresponding updates to the wrapper scripts and CHANGELOG.
- Updated version strings in mvnw.cmd to reflect Maven Wrapper version 3.3.2.
- Adjusted properties in .mvn/wrapper/maven-wrapper.properties to point to the new Maven distribution and to introduce new keys (wrapperVersion, distributionType).
- Updated CHANGELOG.md to document these version bumps.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mvnw.cmd | Updated batch script to reflect the new wrapper version and added a mixed PowerShell block for enhanced processing. |
| CHANGELOG.md | Updated the changelog to list the bumped dependency versions. |
| .mvn/wrapper/maven-wrapper.properties | Modified properties to update Maven distribution and wrapper versions. |
Comments suppressed due to low confidence (2)
mvnw.cmd:30
- Consider adding an inline comment explaining the purpose of initializing MVNW_ARG0_NAME (and the related environment variables) to assist future maintainers.
@IF "%__MVNW_ARG0_NAME__%"=="" (SET __MVNW_ARG0_NAME__=%~nx0)
mvnw.cmd:35
- Consider adding inline comments to clarify the interaction between the batch section and the embedded PowerShell block, outlining the conversion process for improved readability.
@FOR /F "usebackq tokens=1* delims==" %%A IN (`powershell -noprofile "& {$scriptDir='%~dp0'; $script='%__MVNW_ARG0_NAME__%'; icm -ScriptBlock ([Scriptblock]::Create((Get-Content -Raw '%~f0'))) -NoNewScope}"`) DO @(