fix(tty_roles.py): handle role assignment errors by electron271 · Pull Request #864

fix(tty_roles.py): handle role assignment errors by electron271 · Pull Request #864 · allthingslinux/tux

fixes issue if user is kicked/leaves within 5 seconds

Summary by Sourcery

Bug Fixes:

Catch discord.NotFound during delayed role assignment to detect if the member left or was kicked and log an info message instead of an error.

Reviewer's Guide

This PR enhances the role assignment logic by catching and handling discord.NotFound errors—specifically to detect if a member has left or been kicked before a delayed role assignment—and logs accordingly to avoid silent failures.

File-Level Changes

Change	Details	Files
Add explicit handling for NotFound errors during delayed role assignment	Wrap member.add_roles in except discord.NotFound Verify member still exists in guild before retry Log info if member left/kicked; log error otherwise	`tux/cogs/services/tty_roles.py`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @electron271 - I've reviewed your changes and they look great!

Here's what I looked at during the review

🟡 General issues: 1 issue found
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

		if member.guild.get_member(member.id) is None:
		logger.info(f"Member {member} left or got kicked by the server before the role could be assigned.")
		return
		logger.error(f"Failed to assign role {role.name} to {member}: {error}")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider lowering log level for expected NotFound errors

If a missing member is truly unexpected, keep the error level; otherwise (e.g. role deletion or race condition), switch to warning or debug to reduce log noise.

Deploying tux with Cloudflare Pages

View logs